Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package Editor WPF Text with Windows Dark Theming #148

Closed
scottina123 opened this issue Sep 20, 2019 · 3 comments
Closed

Package Editor WPF Text with Windows Dark Theming #148

scottina123 opened this issue Sep 20, 2019 · 3 comments
Assignees

Comments

@scottina123
Copy link

scottina123 commented Sep 20, 2019

Issue: Currently, Package Editor WPF displays black text on imports and exports if you choose a dark theme. @Mgamerz told me its because Package Editor does not use system colors and told me to paste this from discord.

        {
            get => Entry == null ? System.Windows.Media.Brushes.Black : UIndex > 0 ? System.Windows.Media.Brushes.Black : System.Windows.Media.Brushes.Gray;
            set
            {
                _foregroundColor = value;
                OnPropertyChanged();
            }
        }

Proposed Solution: Make it so that Package Editor WPF uses system colors. If possible, have the hexbox be dependent on system colors as well.

Here is a screenshot of what WPF looks like with a dark theme now.
Capture

@Mgamerz
Copy link
Member

Mgamerz commented Sep 22, 2019

For documentation purposes, this is an issue with your custom windows theme, not the official Windows Dark Theme. It cannot theme our application in certain areas as we hardcode the colors rather than using system defaults, which at times is required for the application to look appropriate.

@scottina123
Copy link
Author

@SirCxyrtyx looks like the export import and names tab is still showing black text. Can anything be done about this?

ME3Explorer_2019-09-24_23-09-01

Mgamerz added a commit that referenced this issue Sep 25, 2019
@Mgamerz
Copy link
Member

Mgamerz commented Sep 25, 2019

This should be fixed now, please try build from #me3explorer_autobuilds channel once this commit's build has completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants