Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow disks cause issues in Installation Information panel when restoring #411

Closed
Mgamerz opened this issue May 30, 2024 · 1 comment
Closed
Labels
bug Something isn't working Needs validation Feature is implemented and needs testing and/or feedback
Milestone

Comments

@Mgamerz
Copy link
Member

Mgamerz commented May 30, 2024

When restoring individual files, or removing DLC mods in Installation Information, if the filesystem is taking a long time to return the file list (such as using a USB storage volume), this can cause race conditions where it duplicates the data shown in the panel. This needs to be handled to prevent issues.

@Mgamerz Mgamerz added the bug Something isn't working label May 30, 2024
@Mgamerz Mgamerz added this to the 9.0 milestone May 30, 2024
@Mgamerz Mgamerz added Needs validation Feature is implemented and needs testing and/or feedback labels Jun 5, 2024
@Mgamerz
Copy link
Member Author

Mgamerz commented Jun 5, 2024

This issue was due to notifyDeleted() callback of DLC mod deletion method triggering an entire reload of modified data, rather than just the DLC mods list. On slow disks this could cause duplication as they'd both start and then later both finish, but the list of basegame files was only cleared at the start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Needs validation Feature is implemented and needs testing and/or feedback
Projects
None yet
Development

No branches or pull requests

1 participant