Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of M-Elo #1

Merged
merged 12 commits into from
Aug 1, 2024
Merged

Integration of M-Elo #1

merged 12 commits into from
Aug 1, 2024

Conversation

Nimeggis
Copy link
Member

Checklist for reviewer

  • The code works and does not throw errors
  • The code is easy to understand and there are no confusing parts
  • The code follows the coding guidelines of this project
  • The code change accomplishes what it is supposed to do
  • I cannot think of any use case in which the code does not behave as intended
  • The added and existing tests reasonably cover the code change
  • I cannot think of any test cases, input or edge cases that should be tested in addition
  • Description of the change is included in the documentation

@PaulBredl
Copy link
Contributor

In dem PR sind einige SonarQube Issues. Die sind glaube ich alle nicht schlimm, dauern aber auch wahrscheinlich nicht lang zu fixen. Muss Niklas entscheiden, wie man damit umgeht. Wäre natürlich besser, wenns Quality Gate durchläuft

@myluki2000 myluki2000 merged commit 09fe920 into main Aug 1, 2024
1 of 2 checks passed
@myluki2000 myluki2000 deleted the integration-of-MElo branch August 1, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants