Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Reset Filters" does not work properly #81

Open
aphilop opened this issue May 18, 2022 · 1 comment
Open

"Reset Filters" does not work properly #81

aphilop opened this issue May 18, 2022 · 1 comment
Labels
bug Something isn't working feature: missing This label means that the issue needs to be linked to a precise feature label. role: back end/devOps Tasks for back-end developers size: missing

Comments

@aphilop
Copy link
Contributor

aphilop commented May 18, 2022

Problem description

  1. When resetting the filters, any selected checkbox remains selected, which leads to confusion and then the filter mechanism does not work anymore.
  2. In mobile view, when pressing the "Reset Filters" button, the dialog does not close automatically (as when deselecting a checkbox).

Steps to reproduce problem 1

Tested with Safari and Firefox in MacOS Big Sur

  1. Goto MERL Center Home page (or any other page when the filters are available).
  2. Select a category type, e.g., Case Studies.
  3. The list of articles is updated accordingly.
  4. Press the "Reset Filters" button.
  5. The list of articles is updated accordingly, but the selected checkbox remains selected.

image

Steps to reproduce problem 2

Tested with Safari in iOS 15.4.1

  1. Goto MERL Center Home page (or any other page when the filters are available).
  2. Press the "Filters" button.
  3. The filters dialog opens.
  4. Select a category type, e.g., Case Studies.
  5. The dialog closes automatically and the list of articles is updated accordingly.
  6. Press the "Filters" button again so that the filters dialog opens.
  7. Press the "Reset Filters" button
  8. The list is updated but the dialog remains open.

Reset filters iOS

Expected behavior

  1. When pressing the "Reset Filters" button, any selected checkbox must be deselected.
  2. When pressing the "Reset Filters" button, the filters dialog must close automatically.
@aphilop aphilop added the bug Something isn't working label May 18, 2022
@malakumar85
Copy link
Member

@andrewrmn - can you take a look?

@Rabia2219 Rabia2219 added role: missing feature: missing This label means that the issue needs to be linked to a precise feature label. size: missing role: back end/devOps Tasks for back-end developers and removed role: missing feature: missing This label means that the issue needs to be linked to a precise feature label. labels Aug 31, 2023
PradnyaB17 pushed a commit to PradnyaB17/MERL-Center-public that referenced this issue Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature: missing This label means that the issue needs to be linked to a precise feature label. role: back end/devOps Tasks for back-end developers size: missing
Projects
Status: Emergent Request
Development

No branches or pull requests

5 participants
@malakumar85 @andrewrmn @Rabia2219 @aphilop and others