Skip to content

Fix Phoenix template for real #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 25, 2025
Merged

Conversation

wilfonba
Copy link
Collaborator

Description

Updates Phoenix template to use srun rather than mpirun. Minor source code change to trigger full CI as well.

wilfonba and others added 4 commits April 23, 2025 14:53
@wilfonba wilfonba requested review from a team as code owners April 25, 2025 01:29
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 43.63%. Comparing base (068da2c) to head (2207581).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/simulation/m_time_steppers.fpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #824   +/-   ##
=======================================
  Coverage   43.63%   43.63%           
=======================================
  Files          66       66           
  Lines       19835    19835           
  Branches     2433     2433           
=======================================
  Hits         8655     8655           
  Misses       9688     9688           
  Partials     1492     1492           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbryngelson sbryngelson merged commit 2e5ff46 into MFlowCode:master Apr 25, 2025
27 of 28 checks passed
sbryngelson added a commit that referenced this pull request Apr 25, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
This reverts commit 2e5ff46.
sbryngelson added a commit that referenced this pull request Apr 25, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants