Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create optional cleanup script, especially for reporting. #181

Open
5 tasks
colindaven opened this issue Sep 29, 2021 · 5 comments
Open
5 tasks

create optional cleanup script, especially for reporting. #181

colindaven opened this issue Sep 29, 2021 · 5 comments

Comments

@colindaven
Copy link
Contributor

  • reporting
  • bams?
  • rm fastqs
  • gzip R1.fastq
  • reduce no of files
  • [ ]
@LisaHollstein
Copy link
Contributor

Is this still needed? I could write something for this

@colindaven
Copy link
Contributor Author

colindaven commented Jan 17, 2022

Yes, I just committed what I have to dev.

Further ideas:

  • remove big files in raspir subdir
  • old reporting files are not used if haybaler output folders are filled - so can be deleted. Ie. noone looks at reporting, just haybaler : STOP - we need the reporting files for code report integration, as one sample per file, whereas haybaler has many samples per file.
  • in plots, multiple image folders are created. Could delete old image subfolders (run plots many times to test)
  • ...

@LisaHollstein
Copy link
Contributor

I just noticed an error in wochenende_cleanup.sh:

base_dir=$(pwd)
echo $base_dir
echo "INFO: removing png files from growth_rate"
# a find exec rm is dangerous though, so go more targeted
cd growth_rate
#find . -n
cd $bash_dir

A variable bash_dir is never declared, this should probably mean base_dir, which is declared at the beginning of the script.

@colindaven
Copy link
Contributor Author

True, ups, will correct and add a pipefail statement.

@colindaven
Copy link
Contributor Author

I used
set -u pipefail
to check for unused variables.

See https://vaneyckt.io/posts/safer_bash_scripts_with_set_euxo_pipefail/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants