Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: e-Statの1kmメッシュの読み込みが壊れている #48

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

ciscorn
Copy link
Member

@ciscorn ciscorn commented Jun 30, 2024

Summary by CodeRabbit

  • バグ修正
    • grid_square_code_to_bbox関数の改良により、入力コードの長さに基づいてバウンディングボックス座標を正確に計算できるようになりました。

@ciscorn ciscorn self-assigned this Jun 30, 2024
Copy link

coderabbitai bot commented Jun 30, 2024

Warning

Review failed

The pull request is closed.

ウォークスルー

gridsquare_to_box.py内の関数grid_square_code_to_bboxが、入力コードの長さに応じてバウンディングボックスの座標を計算し、異なる距離の計算にも対応できるように修正されました。この変更により、さまざまな長さのグリッドコードに基づいた精度の異なるボックスを生成できるようになります。

変更点

ファイル 変更内容
japanese_grids/algorithms/.../gridsquare_to_box.py grid_square_code_to_bbox 関数が入力コードの長さに応じてバウンディングボックスの座標を調整するように更新されました。

四角いコードに浮かぶ夢、
バウンディングボックスの新しい計算手、
長さに応じて変化する、
その精度に皆が驚く、
🐇賢いウサギが導いた、新たな旅へ行こうね!🌐


Tip

Early access features: enabled

We are currently testing the following features in early access:

  • OpenAI gpt-4o model for code reviews and chat: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available.

Note:

  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
  • Please join our Discord Community to provide feedback and report issues.
  • OSS projects are always opted into early access features.
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

lat10 = int(code[6]) * 0.125
lng10 = int(code[7]) * 0.125
if length == 8:
lat1 = lat + lat10 / 10
lng1 = lng + lng10 / 10
lat2 = lat + (lat10 + 0.125) / 10
lng2 = lng + (lng10 + 0.125) / 10
return (lng1, lat1 / 1.5, lng, lat / 1.5)
return (lng1, lat1 / 1.5, lng2, lat2 / 1.5)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

原因

@ciscorn ciscorn merged commit 9573e70 into main Jun 30, 2024
3 checks passed
@ciscorn ciscorn deleted the fix-estat-1km branch June 30, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant