Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement multi-index (bandpass-like) graph split #18

Merged
merged 3 commits into from
Jul 14, 2022

Conversation

smoia
Copy link
Collaborator

@smoia smoia commented Jul 14, 2022

Closes #

Proposed Changes

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@smoia smoia added the Minormod This PR generally closes an `Enhancement` issue. It increments the minor version (0.+1.0) label Jul 14, 2022
@smoia smoia marked this pull request as ready for review July 14, 2022 15:11
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #18 (be05e07) into master (cf27a74) will decrease coverage by 0.07%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
- Coverage   76.55%   76.48%   -0.08%     
==========================================
  Files          13       13              
  Lines        1062     1080      +18     
==========================================
+ Hits          813      826      +13     
- Misses        249      254       +5     
Impacted Files Coverage Δ
nigsp/operations/timeseries.py 79.34% <68.42%> (-2.94%) ⬇️
nigsp/utils.py 95.34% <100.00%> (+0.61%) ⬆️

@smoia smoia merged commit 6b8c044 into MIPLabCH:master Jul 14, 2022
@smoia smoia deleted the multisplit_graph branch July 14, 2022 17:37
@smoia smoia added the Released This PR has been released! label Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minormod This PR generally closes an `Enhancement` issue. It increments the minor version (0.+1.0) Released This PR has been released!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant