Skip to content

Commit

Permalink
pinctrl: JZ4780: Add missing breaks in switch and rename IRQ chip
Browse files Browse the repository at this point in the history
The name of the IRQ chip appears in /proc/interrupts, and it does not
look good if it is too long (the other interrupt sources have very short
names).

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
  • Loading branch information
pcercuei authored and Zubair Lutfullah Kakakhel committed Jun 30, 2015
1 parent e3d0871 commit f65a81c
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion drivers/pinctrl/pinctrl-jz4780.c
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ static int jz4780_gpio_irq_set_type(struct irq_data *irqd, unsigned int type)
}

static struct irq_chip jz4780_gpio_irq_chip = {
.name = "jz4780_gpio_irq_chip",
.name = "GPIO",
.irq_unmask = jz4780_gpio_irq_unmask,
.irq_mask = jz4780_gpio_irq_mask,
.irq_ack = jz4780_gpio_irq_ack,
Expand Down Expand Up @@ -495,14 +495,17 @@ static int jz4780_pinconf_get(struct pinctrl_dev *pctldev,
case PIN_CONFIG_BIAS_DISABLE:
if (pull)
return -EINVAL;
break;

case PIN_CONFIG_BIAS_PULL_UP:
if (!pull || !(jzgc->pull_ups & (1 << idx)))
return -EINVAL;
break;

case PIN_CONFIG_BIAS_PULL_DOWN:
if (!pull || !(jzgc->pull_downs & (1 << idx)))
return -EINVAL;
break;

default:
return -ENOTSUPP;
Expand Down

0 comments on commit f65a81c

Please sign in to comment.