-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MISPtoSTIX() uses example XML namespace #21
Comments
Sounds good to me, sadly we need to use ns_dict to avoid issues with the framing system so indeed, injecting a custom namespace via a parameter when calling the script sounds like the cleanest option. |
Pretty sure this involves not using STIX tbh
It does make sense to maintain one single converter for sure - this sounds like the best way to go about it - if we're calling it from the shell we can just add a flag for it 🎏 are cool |
I wanted to die more than usual so I did this as I was already insane I am horrified to announce that
are all valid flags on the converter now. Example
Should work |
oh you want the function to use it EHHHH |
once more unto the breach once more
|
Wow, 01a30bd looks a lot simpler than what I had in mind. Will try to test it next week. |
I'm preparing a patch for this (and other STIX best practices) but one mayor issue is that currently MISPtoSTIX() returns a STIXPackage and lets the main program do the to_xml() call. Since a custom namespace is defined by using the ns_dict parameter of to_xml() this complicates things quite a lot.
One solution I see is to pass the required format (json/xml) to MISPtoSTIX() along with the custom namespace. Or is there a better way to deal with this?
The text was updated successfully, but these errors were encountered: