Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds previous credential applications to admin user profile #1260

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

Lucas-Mc
Copy link
Contributor

@Lucas-Mc Lucas-Mc commented Feb 8, 2021

This change adds previous credential applications to the admin user profile in order to more effectively review new credential applications, specifically for those who must re-submit due to insufficient information.

@tompollard
Copy link
Member

tompollard commented Feb 8, 2021

This successfully adds the previous applications to the user management page, but the way the information is displayed could be cleaner. Currently all previous applications get dropped into the user management page, which kind of dominates the page. Could the previous applications instead be displayed on a separate "application history page"?

@Lucas-Mc
Copy link
Contributor Author

Lucas-Mc commented Feb 8, 2021

This is possible, but wouldn't we still want that to be tied to the user management page so all the information regarding the user is in the same place? Or did you mean separate tabs on that page maybe for personal info, projects, and credential applications?

@tompollard
Copy link
Member

This looks pretty good, but it allows any registered user to view someone's application history. e.g. try logging in as rgmark (a non-admin user) and viewing http://localhost:8000/settings/credentialing/applications/aewj/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants