Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relaxes requirements for pytz #275

Merged
merged 1 commit into from
Jan 6, 2021
Merged

Relaxes requirements for pytz #275

merged 1 commit into from
Jan 6, 2021

Conversation

Lucas-Mc
Copy link
Collaborator

@Lucas-Mc Lucas-Mc commented Jan 5, 2021

This change relaxes the requirements for the pytz package from >=2018.3 to >= 2017.2 since it is only required by pandas which only requires pytz>=2017.2.

@tompollard
Copy link
Member

Could you explain why it is necessary to relax the requirement? What is the pytz package and which version are we running on the server?

@Lucas-Mc
Copy link
Collaborator Author

Lucas-Mc commented Jan 5, 2021

From the most recent PhysioNet build:

The conflict is caused by:
    The user requested pytz==2017.2
    django 2.2.13 depends on pytz
    google-api-core 1.13.0 depends on pytz
    pandas 1.1.0 depends on pytz>=2017.2
    wfdb 3.1.2 depends on pytz>=2018.3

That original requirement was too strict since when I removed it from requirements.txt for WFDB-Python only >=2017.2 was required. The version should be 2017.2 based on the requirements.txt for PhysioNet.

@briangow briangow merged commit a36a2ac into master Jan 6, 2021
@briangow briangow deleted the update_reqs branch January 6, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants