Dependency updates #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- includes unpinning lxml and associated instructions on how to use `brew` version of `libxml2` by setting `PKG_CONFIG_PATH` env to `brew` installed path. This change allows working outside of containers for local development
ghukill
approved these changes
May 14, 2024
There was a problem hiding this comment.
Looks good to me. Think unpinning versions, wherever possible, is handy for easier updates.
As discussed in slack, seems TBD if this section about running in docker for dev work is still needed.
But at the very least, seems as though this line:
Additionally,
lxmlversions newer than 4.9.4 crash python3-saml
could be removed, as I believe I can successfully run the flask app locally, with the IDP docker container, and login with the following versions:
lxml==5.2.2
python3-saml==1.16.0
With that line removed, all else looks good.
|
Thanks @ghukill . I tweaked the docs a bit to clarify that while docker remains an option, it is no longer required for local development. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brewversion oflibxml2by settingPKG_CONFIG_PATHenv tobrewinstalled path. This change allows working outside of containers for local development