Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove boilerplate allowed_push_host restriction #51

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Conversation

matt-bernhardt
Copy link
Member

@matt-bernhardt matt-bernhardt commented Jan 30, 2023

** Why are these changes being introduced:

  • There is a boilerplate line in the gemspec file to restrict which sites can have releases pushed to them. We have not had this line in the past, and its presence appears to be part of the initial protections that need to be edited or removed.

** Relevant ticket(s):

  • n/a

** How does this address that need:

  • After considering whether to update this directive, or remove it entirely, it seems consistent with past practice to remove it entirely so this is what this PR does.

** Document any side effects to this change:

  • None (we are free to consider implementing a real value for this, and reintroducing the directive, in a future ticket)

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

NO

Includes new or updated dependencies?

NO

** Why are these changes being introduced:

* There is a boilerplate line in the gemspec file to restrict which
  sites can have releases pushed to them. We have not had this line in
  the past, and its presence appears to be part of the initial
  protections that need to be edited or removed.

** Relevant ticket(s):

* n/a

** How does this address that need:

* After considering whether to update this directive, or remove it
  entirely, it seems consistent with past practice to remove it entirely
  so this is what this PR does.

** Document any side effects to this change:

* None (we are free to consider implementing a real value for this, and
  reintroducing the directive, in a future ticket)
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2d468622725c04187709c89f850792e8aec2b23a-PR-51

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.372%

Totals Coverage Status
Change from base Build 6c59d1af2fd2cd247fab30cce692061b7d024053: 0.0%
Covered Lines: 38
Relevant Lines: 43

💛 - Coveralls

@matt-bernhardt matt-bernhardt merged commit f53eb6e into main Jan 30, 2023
@matt-bernhardt matt-bernhardt deleted the fixup branch January 30, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants