Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display title in nav only if PLATFORM_NAME is not set #59

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

jazairi
Copy link
Contributor

@jazairi jazairi commented Feb 9, 2024

Why these changes are being introduced:

The app name is inserted into the header based on the PLATFORM_NAME environment variable. If this variable is set, the title should not display

Relevant ticket(s):

https://mitlibraries.atlassian.net/browse/GDT-124

How this addresses that need:

This makes the title in the nav render if PLATFORM_NAME is not set.

Side effects of this change:

We will need to make this change downstream, as most (if not all) of our Rails properties have customized the site nav partial.

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

NO

Includes new or updated dependencies?

NO

Why these changes are being introduced:

The app name is inserted into the header based on the `PLATFORM_NAME`
environment variable. If this variable is set, the title should
not display

Relevant ticket(s):

https://mitlibraries.atlassian.net/browse/GDT-124

How this addresses that need:

This makes the title in the nav render if `PLATFORM_NAME` is not
set.

Side effects of this change:

We will need to make this change downstream, as most (if not all)
of our Rails properties have customized the site nav partial.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7846364563

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.372%

Totals Coverage Status
Change from base Build 7845201893: 0.0%
Covered Lines: 38
Relevant Lines: 43

💛 - Coveralls

@jazairi jazairi merged commit ca56f70 into main Feb 9, 2024
2 checks passed
@jazairi jazairi deleted the conditional-nav-title branch February 9, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants