Display title in nav only if PLATFORM_NAME is not set #59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
The app name is inserted into the header based on the
PLATFORM_NAME
environment variable. If this variable is set, the title should not displayRelevant ticket(s):
https://mitlibraries.atlassian.net/browse/GDT-124
How this addresses that need:
This makes the title in the nav render if
PLATFORM_NAME
is not set.Side effects of this change:
We will need to make this change downstream, as most (if not all) of our Rails properties have customized the site nav partial.
Developer
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Code Reviewer
(not just this pull request message)
Requires database migrations?
NO
Includes new or updated dependencies?
NO