Make Zeek 5.1 compatible #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently this plugin fails with Zeek 5.1 due to the following error:
src/HTTP2.cc:146:13: error: ‘ProtocolConfirmation’ was not declared in this scope; did you mean ‘LN_protocolInformation’?
146 | ProtocolConfirmation(); // Notify system that this is HTTP2.
| ^~~~~~~~~~~~~~~~~~~~
| LN_protocolInformation
src/HTTP2.cc:158:17: error: ‘ProtocolViolation’ was not declared in this scope
158 | ProtocolViolation("Unable to parse http 2 frame from data stream, fatal error");
With Zeek 5.1 ProtocolConfirmation() and ProtocolViolation() have been
removed. Since Zeek 4.2 there's AnalyzerConfirmation() and
AnalyzerViolation() available.
awelzel
force-pushed
the
analyzer-protocol-rename
branch
from
3402520 to
272a64f
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this plugin fails to compile with Zeek 5.1 due to the following error:
With Zeek 5.1 ProtocolConfirmation() and ProtocolViolation() have been removed. Since Zeek 4.2 there's AnalyzerConfirmation() and AnalyzerViolation() available.