Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

Update readme #455

Merged
merged 4 commits into from
Nov 1, 2023
Merged

Update readme #455

merged 4 commits into from
Nov 1, 2023

Conversation

EthanMarx
Copy link
Collaborator

closes #350 and #451

@EthanMarx
Copy link
Collaborator Author

@wbenoit26 Ready for review. If theres anything else to add or expand upon now let me know

wbenoit26
wbenoit26 approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@wbenoit26 wbenoit26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'd say we should make the instructions shell-agnostic, but honestly if anyone's not using bash they can probably figure out which file the commands should go in

@EthanMarx
Copy link
Collaborator Author

I would say that is a good assumption

@EthanMarx EthanMarx merged commit b661ba9 into ML4GW:main Nov 1, 2023
2 checks passed
@EthanMarx EthanMarx deleted the update-readme branch November 1, 2023 21:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wbenoit26 wbenoit26 wbenoit26 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add instructions to README for KRB5_KTNAME and X509_USER_PROXY
2 participants
@EthanMarx @wbenoit26