Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create tensor on proper device in IMRPhenomPv2 #183

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Create tensor on proper device in IMRPhenomPv2 #183

merged 3 commits into from
Jan 10, 2025

Conversation

EthanMarx
Copy link
Collaborator

  • Fixes issue in IMRPhenomPv2 where a tensor wasn't allocated on the correct device
  • Divides the testing parameter space into close and far distances for IMRPhenomPv2
  • Adds batched test for IMRPhenomPv2

deepchatterjeeligo
deepchatterjeeligo approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@deepchatterjeeligo deepchatterjeeligo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great

@EthanMarx EthanMarx merged commit a3ba42d into main Jan 10, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepchatterjeeligo deepchatterjeeligo deepchatterjeeligo approved these changes

@ravioli1369 ravioli1369 Awaiting requested review from ravioli1369

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EthanMarx @deepchatterjeeligo