Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modeler cleanup #72

Merged
merged 24 commits into from
Feb 8, 2021
Merged

Modeler cleanup #72

merged 24 commits into from
Feb 8, 2021

Conversation

ChengFR
Copy link
Collaborator

@ChengFR ChengFR commented Feb 7, 2021

The following tasks are resolved in this pull request:

Copy link
Collaborator

@sarahmish sarahmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New modeler looks great @ChengFR!

cardea/modeling/modeler.py Show resolved Hide resolved
cardea/modeling/modeler.py Outdated Show resolved Hide resolved
cardea/modeling/modeler.py Outdated Show resolved Hide resolved
cardea/modeling/modeler.py Outdated Show resolved Hide resolved
cardea/modeling/modeler.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
cardea/modeling/modeler.py Show resolved Hide resolved
cardea/modeling/modeler.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@sarahmish sarahmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dyuliu dyuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much clean and better organized. Good job.

import numpy as np
import pandas as pd
from hyperopt import STATUS_OK, Trials, base, fmin, hp, tpe
import sklearn
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks the lib order is not optimized.

we can use the following commands to automatically fix the import order issue.
isort --apply --atomic --recursive cardea

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried isort, but nothing changed. It seems that the current order is correct.

@dyuliu dyuliu merged commit bbac229 into master Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up the modeler Update and clean up the dependencies
3 participants