Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/generate source map #6

Merged
merged 5 commits into from
Aug 11, 2020
Merged

Feat/generate source map #6

merged 5 commits into from
Aug 11, 2020

Conversation

jessieAnhNguyen
Copy link
Member

Summary:

Test Plan:

@jessieAnhNguyen jessieAnhNguyen linked an issue Aug 10, 2020 that may be closed by this pull request
4 tasks
"files.exclude": {
"**/.git": true,
"**/node_modules": true,
"**/node_modules": false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing the settings.json changes weren't intentional?

const IP_ADDRESS = ip.address();
const PLATFORM = 'android';
const requestURL = `http://${IP_ADDRESS}:${DEBUG_SERVER_PORT}/index.map?platform=${PLATFORM}&dev=true`;
return (await axios.get(requestURL)) as AxiosResponse<SourceMap>;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need axios for this. Taking the dependency for a single http request is most likely not going to be popular among the react-native-cli maintainers

@jessieAnhNguyen jessieAnhNguyen marked this pull request as ready for review August 11, 2020 09:34
Copy link
Collaborator

@jevakallio jevakallio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamping this, will address issues in group programming session

@jevakallio jevakallio merged commit 1cff3c8 into master Aug 11, 2020
@jessieAnhNguyen jessieAnhNguyen deleted the feat/generate-source-map branch August 11, 2020 12:27
@jessieAnhNguyen jessieAnhNguyen self-assigned this Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate/ find the source map file
2 participants