Pre-publish changes before making a PR to RN CLI #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Implemented a new command to download Hermes Sampling Profiler to a local machine
1. Purpose:
2. Usage:
destinationDir
is optional, if provided, pull the file to that directoryOptions
--fileName [string]
File name of the profile to be downloaded, eg. sampling-profiler-trace8593107139682635366.cpuprofile.
--verbose
Lists commands and steps that are run internally to pull the file from Android device
--raw
Pulls the original Hermes tracing profile without any transformation
--sourcemap-path [string]
The local path to your source map file if you generated it manually, ex.
/tmp/sourcemap.json
--generate-sourcemap
Generate the JS bundle and source map in
os.tmpdir()
Notes on source map
This step is recommended in order for the source map to be generated:
If you are planning on building a debug APK, that will run without the packager, by invoking
./gradlew assembleDebug
you can simply setbundleInDebug: true
in your app/build.gradle file, inside theproject.ext.react
map.Test Plan:
yarn
yarn lint
yarn link
as instructed by the CLI's Testing Plan.react-native profile-hermes
as per instruction aboveExample output of running the command