Customer.io Trigger Node #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erin2722
reviewed
Jul 2, 2020
| @@ -19,8 +19,8 @@ export async function awsApiRequest(this: IHookFunctions | IExecuteFunctions | I | |||
| const endpoint = `${service}.${credentials.region}.amazonaws.com`; | |||
|
|
|||
| // Sign AWS API request with the user credentials | |||
| const signOpts = {headers: headers || {}, host: endpoint, method, path, body}; | |||
| sign(signOpts, {accessKeyId: `${credentials.accessKeyId}`, secretAccessKey: `${credentials.secretAccessKey}`}); | |||
| const signOpts = { headers: headers || {}, host: endpoint, method, path, body }; | |||
There was a problem hiding this comment.
Make sure not to change other files in your PRs!
There was a problem hiding this comment.
oh ya I'll make sure to remove it
| import { OptionsWithUri } from 'request'; | ||
| import { IDataObject } from 'n8n-workflow'; | ||
|
|
||
| export async function apiRequest(this: IHookFunctions | IExecuteFunctions | ILoadOptionsFunctions, method: string, endpoint: string, body: object, query?: IDataObject): Promise<any> { // tslint:disable-line:no-any |
There was a problem hiding this comment.
to go w codebase conventions, name this customerIoApiRequest
There was a problem hiding this comment.
ya, I'll make the changes
| }, | ||
| method, | ||
| body, | ||
| qs: query, |
There was a problem hiding this comment.
name the param qs so that you can write qs,
| @@ -1,19 +1,19 @@ | |||
| import { | |||
| IHookFunctions, | |||
| IWebhookFunctions, | |||
| } from 'n8n-core'; | |||
| } from 'n8n-core'; | |||
There was a problem hiding this comment.
Also make sure to leave out this file!
ivov
requested changes
Jul 2, 2020
There was a problem hiding this comment.
Hey @Shraddha2104! Small details.
Linter errors:
ERROR: C:/Users/IvanOv/Desktop/third/n8n/packages/nodes-base/nodes/CustomerIo/CustomerIoTrigger.node.ts:242:9 - Identifier 'events_list' is never reassigned; use 'const' instead of 'var'.
ERROR: C:/Users/IvanOv/Desktop/third/n8n/packages/nodes-base/nodes/CustomerIo/CustomerIoTrigger.node.ts:242:9 - variable name must be in lowerCamelCase or UPPER_CASE
ERROR: C:/Users/IvanOv/Desktop/third/n8n/packages/nodes-base/nodes/CustomerIo/CustomerIoTrigger.node.ts:242:39 - Type declaration of 'any' loses type-safety. Consider replacing it with a more precise type.
ERROR: C:/Users/IvanOv/Desktop/third/n8n/packages/nodes-base/nodes/CustomerIo/CustomerIoTrigger.node.ts:244:6 - Forbidden 'var' keyword, use 'let' or 'const' instead
ERROR: C:/Users/IvanOv/Desktop/third/n8n/packages/nodes-base/nodes/CustomerIo/CustomerIoTrigger.node.ts:244:10 - Identifier 'obj' is never reassigned; use 'const' instead of 'var'.
ERROR: C:/Users/IvanOv/Desktop/third/n8n/packages/nodes-base/nodes/CustomerIo/CustomerIoTrigger.node.ts:245:6 - Forbidden 'var' keyword, use 'let' or 'const' instead
ERROR: C:/Users/IvanOv/Desktop/third/n8n/packages/nodes-base/nodes/CustomerIo/CustomerIoTrigger.node.ts:245:10 - Identifier 'key' is never reassigned; use 'const' instead of 'var'.
ERROR: C:/Users/IvanOv/Desktop/third/n8n/packages/nodes-base/nodes/CustomerIo/CustomerIoTrigger.node.ts:246:6 - Forbidden 'var' keyword, use 'let' or 'const' instead
ERROR: C:/Users/IvanOv/Desktop/third/n8n/packages/nodes-base/nodes/CustomerIo/CustomerIoTrigger.node.ts:246:10 - Identifier 'val' is never reassigned; use 'const' instead of 'var'.
ERROR: C:/Users/IvanOv/Desktop/third/n8n/packages/nodes-base/nodes/CustomerIo/CustomerIoTrigger.node.ts:249:7 - Forbidden 'var' keyword, use 'let' or 'const' instead
ERROR: C:/Users/IvanOv/Desktop/third/n8n/packages/nodes-base/nodes/CustomerIo/CustomerIoTrigger.node.ts:249:11 - Identifier 'value' is never reassigned; use 'const' instead of 'var'.
ERROR: C:/Users/IvanOv/Desktop/third/n8n/packages/nodes-base/nodes/CustomerIo/CustomerIoTrigger.node.ts:253:7 - Forbidden 'var' keyword, use 'let' or 'const' instead
ERROR: C:/Users/IvanOv/Desktop/third/n8n/packages/nodes-base/nodes/CustomerIo/CustomerIoTrigger.node.ts:253:11 - Identifier 'obj1' is never reassigned; use 'const' instead of 'var'.
ERROR: C:/Users/IvanOv/Desktop/third/n8n/packages/nodes-base/nodes/Google/Task/GenericFunctions.ts:19:8 - Type declaration of 'any' loses type-safety. Consider replacing it with a more precise type.
ERROR: C:/Users/IvanOv/Desktop/third/n8n/packages/nodes-base/nodes/Google/Task/GenericFunctions.ts:23:12 - Type declaration of 'any' loses type-safety. Consider replacing it with a more precise type.
ERROR: C:/Users/IvanOv/Desktop/third/n8n/packages/nodes-base/nodes/Google/Task/GenericFunctions.ts:68:8 - Type declaration of 'any' loses type-safety. Consider replacing it with a more precise type.
ERROR: C:/Users/IvanOv/Desktop/third/n8n/packages/nodes-base/nodes/Google/Task/GenericFunctions.ts:70:12 - Type declaration of 'any' loses type-safety. Consider replacing it with a more precise type.
Comment on lines
228
to
232
| } catch (err) { | ||
| if (err.statusCode === 404) { | ||
| return false; | ||
| } | ||
| throw new Error(`Customer.io Error: ${err}`); |
| const webhookUrl = this.getNodeWebhookUrl('default'); | ||
| const events = this.getNodeParameter('events', []) as string[]; | ||
| const endpoint = '/reporting_webhooks'; | ||
| var events_list: { [key: string]: any } = {}; |
Comment on lines
244
to
255
| var obj = event.split('.'); //push.attempted | ||
| var key = obj[0]; //push | ||
| var val = obj[1]; //attempted | ||
|
|
||
| if (events_list.hasOwnProperty(key)) { | ||
| var value = events_list[key]; | ||
| value[val] = true; | ||
| } | ||
| else { | ||
| var obj1: { [val: string]: boolean; } = { [val]: true }; //{'attempted':true} | ||
| events_list[key] = obj1; | ||
| } |
There was a problem hiding this comment.
Would it be possible to rename obj, key and val using the API names pushAttempted, push and attempted?
Comment on lines
265
to
267
| } catch (e) { | ||
| throw e; | ||
| } |
| const endpoint = `/reporting_webhooks/${webhookData.webhookId}`; | ||
| try { | ||
| await customerIoApiRequest.call(this, 'DELETE', endpoint, {}, {}); | ||
| } catch (e) { |
Comment on lines
7
to
8
| import { OptionsWithUri } from 'request'; | ||
| import { IDataObject } from 'n8n-workflow'; |
There was a problem hiding this comment.
Staggered lines and trailing commas.
|
Submitted to maintainers here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
✨ Added a Customer.io trigger node.
Let me know if it can be refactored anywhere!