-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navbar added #28
Navbar added #28
Conversation
👷 Deploy request for prep-22-p3-1-project pending review.Visit the deploys page to approve it
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a .gitignore
file ignoring environment files and cache files. I gave the same suggestion here #27 (review)
Adding it to either of the PR would solve the purpose.
.eslint file keeps generating everytime the project is locally. This issue is still open facebook/create-react-app#10306 and has not been resolved yet. A fix is deleting the .eslintcache file before commiting the changes pushing them upstream. |
The nav bar looks great! And I see you have integrate some of the changes I made to avoid conflicts on merge! Great job! |
After final changes - This PR closes issues #2 #13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
The images can be moved to a different folder. Something like ./assets/images/cloud.jpeg
. Also, there should be a separate component for backgroundArray
I moved the images to a backgroundArray component and changed the imports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ready to merge! Good job. The changes Mayank help give better structure to the proyect
Added a Navigation bar to traverse the page.
@yashika51 and @PAOK-2001 please review the changes