Fix alert screen crash in android in RNTester app (#21) #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jevakallio
approved these changes
Jun 15, 2020
There was a problem hiding this comment.
LGTM! 🚀
Now let's figure out what's the best way to target this to https://github.com/facebook/react-native
jevakallio
added
the
pending merge
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Jul 13, 2020
Summary: fixes - MLH-Fellowship#21 [Reviewed by jevakallio](MLH-Fellowship#22) ## Changelog Before:  After: <img width="305" alt="Screenshot 2020-06-12 at 11 49 31 AM" src="https://user-images.githubusercontent.com/22813027/84471351-c8b1db00-aca2-11ea-9844-2b06da36e590.png"> Pull Request resolved: #29150 Test Plan: 1. Run the RNTester app locally on both android and iOS. 2. Open the Alert API screen. 3. Alert examples should be visible and functional in both android and iOS. Screenshot for both android and iOS screens- <img width="688" alt="Screenshot 2020-06-12 at 11 52 21 AM" src="https://user-images.githubusercontent.com/22813027/84471544-2d6d3580-aca3-11ea-9142-5f31a3daaf4e.png"> Reviewed By: cpojer Differential Revision: D22067670 Pulled By: rickhanlonii fbshipit-source-id: e7c43b77a30ae2e258303ce84f7fc4dee63776e6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes #21
Changelog
Before:
After:
Test Plan
Screenshot for both android and iOS screens-