Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation URL to examples and remove community screens #224

Merged
merged 3 commits into from
Aug 18, 2020
Merged

Add documentation URL to examples and remove community screens #224

merged 3 commits into from
Aug 18, 2020

Conversation

chirag-singhal
Copy link

@chirag-singhal chirag-singhal commented Aug 18, 2020 •
edited
Loading

Changelog

  • Add documentation URL to examples ( This needs to be maintained in individual screen PRs)
  • Remove community package examples
    • AsyncStorage
    • Clipboard
    • DatePickerAndroid
    • Picker
    • PickerIOS
    • MaskedViewIOS
    • ProgressBarAndroid
    • ProgressViewIOS
    • SegmentedControl
    • SegmentedControlIOS
    • PushNotificationIOS
    • Slider

@chirag-singhal chirag-singhal self-assigned this Aug 18, 2020
@chirag-singhal chirag-singhal added the RNTester The issues associated with the RNTester project. label Aug 18, 2020
YashKumarVerma
YashKumarVerma approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@YashKumarVerma YashKumarVerma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This diff is 🔥

@anku255 anku255 merged commit 026bad2 into mlh-fellowship-migrated-ui-changes Aug 18, 2020
manyaagarwal
manyaagarwal reviewed Aug 18, 2020
View reviewed changes
Copy link

@manyaagarwal manyaagarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manyaagarwal manyaagarwal manyaagarwal left review comments

@anku255 anku255 anku255 approved these changes

@YashKumarVerma YashKumarVerma YashKumarVerma approved these changes

@AnshG714 AnshG714 Awaiting requested review from AnshG714

@sansyrox sansyrox Awaiting requested review from sansyrox

Assignees

@chirag-singhal chirag-singhal

Labels
RNTester The issues associated with the RNTester project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chirag-singhal @YashKumarVerma @anku255 @manyaagarwal