Update dependencies #293
Open
Update dependencies #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
princiya
reviewed
Oct 17, 2020
| @@ -10,8 +10,19 @@ | |||
| "directory": "packages/rn-tester" | |||
| }, | |||
| "dependencies": { | |||
| "anser": "^1.4.9", | |||
There was a problem hiding this comment.
@suminkimm why do we need all these new dependencies?
The idea is to not use third party dependencies inside rn-tester, which is why you see only 2 dependencies used so far --> invariant and nullthrows. 😄
rn-tester is meant to be run as a sample application to try changes made into the react-native core; having 3rd party dependencies means that the new changes made into the react-native core will not be supported by these 3rd party dependencies. in order to avoid this unnecessary overhead usage of other dependencies is avoided.
cc @mkcode
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update dependencies. Running
yarn upgradewas needed to fix the fs-events package.