Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] 👷 build: 0.3.1 #124

Merged
merged 1 commit into from
Aug 12, 2024
Merged

[MRG] 👷 build: 0.3.1 #124

merged 1 commit into from
Aug 12, 2024

Conversation

huangyz0918
Copy link
Contributor

@huangyz0918 huangyz0918 commented Aug 12, 2024

PR Type

enhancement


Description

  • Updated the __version__ variable in mle/version.py from '0.3.0' to '0.3.1'.

Changes walkthrough 📝

Relevant files
Enhancement
version.py
Bump version to 0.3.1                                                                       

mle/version.py

  • Updated the __version__ variable from '0.3.0' to '0.3.1'.
+1/-1     

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 12, 2024
Copy link

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No key issues to review

Copy link

github-actions bot commented Aug 12, 2024

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Score
Enhancement
Use a structured data type for version management

Consider using a more structured approach for version management, such as using a
tuple or a dictionary. This can help in programmatically comparing versions and
managing them more effectively.

mle/version.py [18]

-__version__ = '0.3.1'
+__version_info__ = {'major': 0, 'minor': 3, 'patch': 1}
+__version__ = f"{__version_info__['major']}.{__version_info__['minor']}.{__version_info__['patch']}"
 
Suggestion importance[1-10]: 7

Why: The suggestion to use a structured data type for version management is valid and can help in programmatically comparing and managing versions more effectively. However, it may be an over-engineering for a simple version update in this context.

7

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 12, 2024
@HuaizhengZhang HuaizhengZhang merged commit 8f326dc into main Aug 12, 2024
4 checks passed
@huangyz0918 huangyz0918 deleted the release/0.3.1 branch August 12, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer Review effort [1-5]: 1 size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants