Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(.gitattributes): enforce unix line endings for data files #154

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

wpbonelli
Copy link
Contributor

Automatic lf -> crlf conversion on Windows caused pooch hash check to fail, enforce lf for all text files in the data/ directory. Followup to

For Windows developers it may be necessary to refresh the repository as described here after rebasing with this change.

Other resources

Co-authored-by: Eric Morway <emorway@usgs.gov>
@wpbonelli wpbonelli merged commit b0eaf3f into MODFLOW-USGS:develop Feb 22, 2024
6 checks passed
@wpbonelli wpbonelli deleted the line-endings branch February 22, 2024 18:14
Copy link
Contributor

@emorway-usgs emorway-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attempted to add a comment that clarifies how the two lines interact with one another, other than that, looks good. @wpbonelli and @emorway-usgs previously tested this fix on windows machine in real-time and it worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants