Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(netcdf): address gcc hdf5 build issue on linux #2009

Merged
merged 3 commits into from
Aug 29, 2024
Merged

fix(netcdf): address gcc hdf5 build issue on linux #2009

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f7a782
apply hdf5 build fix to linux
Aug 29, 2024
0acde24
cleanup
Aug 29, 2024
b4f733f
apply expected gcc flags when netcdf not in build
Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ endif

# GCC profile options need to be netcdf aware due to HDF5 issue
if fc_id == 'gcc'
if with_netcdf and build_machine.system() == 'darwin'
if with_netcdf
# HDF5 1.14.3 invalid fpe trap issue: https://github.com/HDFGroup/hdf5/issues/3831
if profile == 'release'
compile_args += ['-ffpe-summary=overflow', '-ffpe-trap=overflow,zero']
Expand Down
Loading