Skip to content

Commit

Permalink
ci: fix eslint & test reports continue even when previous is failing
Browse files Browse the repository at this point in the history
  • Loading branch information
daniele-pelagatti committed Nov 2, 2023
1 parent 5744271 commit 6e035a5
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/test-report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,20 @@ jobs:
run_id: ${{ github.event.workflow_run.id }}

- name: Annotate Src Code Linting Results
if: success() || failure()
uses: ataylorme/eslint-annotate-action@v2
with:
report-json: "reports/eslint-src.json"

- name: Annotate Examples Code Linting Results
if: success() || failure()
uses: ataylorme/eslint-annotate-action@v2
with:
report-json: "reports/eslint-examples.json"


- name: 'Produce test report'
if: success() || failure()
uses: dorny/test-reporter@v1
with:
artifact: build-artifact # artifact name
Expand Down
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,16 +52,16 @@

"check": "concurrently -c auto npm:check:*",
"check:typecheck-src": "tsc --noEmit",
"check:eslint-src": "eslint src/**/*.ts",
"check:eslint-src": "eslint \"src/**/*.ts\"",
"check:typecheck-examples": "tsc --noEmit -p examples",
"check:eslint-examples": "eslint examples/**/*.ts",
"check:eslint-examples": "eslint \"examples/**/*.ts\"",

"ci:test": "JEST_JUNIT_OUTPUT_DIR=reports jest --ci --reporters=default --reporters=jest-junit",
"ci:check": "concurrently npm:ci:check:*",
"ci:check:typecheck-src": "tsc --pretty false --noEmit > reports/typecheck.txt",
"ci:check:eslint-src": "eslint --format json --output-file reports/eslint-src.json src/**/*.ts",
"ci:check:eslint-src": "eslint --format json --output-file reports/eslint-src.json \"src/**/*.ts\"",
"ci:check:typecheck-examples": "tsc --pretty false --noEmit -p examples > reports/typecheck-examples.txt",
"ci:check:eslint-examples": "eslint --format json --output-file reports/eslint-examples.json examples/**/*.ts"
"ci:check:eslint-examples": "eslint --format json --output-file reports/eslint-examples.json \"examples/**/*.ts\""
},
"repository": {
"type": "git",
Expand Down

0 comments on commit 6e035a5

Please sign in to comment.