Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in License applyed #5

Merged
merged 24 commits into from
May 17, 2024
Merged

Changes in License applyed #5

merged 24 commits into from
May 17, 2024

Commits on Feb 12, 2024

  1. Configuration menu
    Copy the full SHA
    c67e5b8 View commit details
    Browse the repository at this point in the history
  2. - the latest changes of license attribute

    - documentation aligned (description in the attributes)
    - added clarification about general license according to spdx and specific license
    MaxThomasHPI committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    2f81ebb View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Update to complete API yml and fix naming error

    The former yml file was just a translation of the json schema. Now the
    yml file describes the whole API. Information about pagination was
    missing as well as HTTP error messages.
    
    yml file had the wrong indention in arrays. Fixing this improved
    readability.
    
    There was a naming error calling the MOOChub schema "moochub_schema.json"
    instead of "moochub-schema.json". This caused problems in matching the
    correct files in the github repository.
    MaxThomasHPI committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    77482fc View commit details
    Browse the repository at this point in the history
  2. Making instructor array again

    There was a mistake that "instructor" was not an array. This was in
    contradiction to the defined schema.
    MaxThomasHPI committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    6cce764 View commit details
    Browse the repository at this point in the history
  3. Add missing spaces in Prof. Dr.

    There were some spaces in the honorific prefix missing in some
    descriptions and examples. This was a clear mistake and made
    reviewing changes unnecessary harder.
    MaxThomasHPI committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    50eca18 View commit details
    Browse the repository at this point in the history
  4. Fix problem with quotation marks in yml

    There was a problem that with generating the yml file by a
    script the quotation marks were sometimes missing in the yml.
    This caused a lot of trouble in reviewing changes in the
    file, since all missing quotation marks were treated as
    changes.
    
    The script was updated and the file shows quotation marks now
    where needed.
    MaxThomasHPI committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    bf89973 View commit details
    Browse the repository at this point in the history
  5. Correct affiliation in instructor attribute

    The affiliation in the instructor attribute was wrongly
    indented. It was part of the image attribute. By correcting
    the indention the affiliation is now part of the Person
    object in the instructor attribute as intended.
    MaxThomasHPI committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    8df56e4 View commit details
    Browse the repository at this point in the history
  6. Improve readability and fix inconsistencies

    There were some problems with data types of attributes.
    Namely, some attributes can have a value of a defined type
    or can be 'null'. In yml this was represented as an array.
    As it is in the json. For consistency, the yml will now
    only show the data type in the type attribute and has a
    nullable attribute as before.
    
    There were still issues with quotation marks that showed
    changes where are none.
    
    In the older version, empty attributes contained the value
    'null'. This will be the case also for the newer version.
    This way, no unnecessary tracking of changes occurs.
    MaxThomasHPI committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    59112a7 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2024

  1. Align style further to old style

    A few discrepancies to the old file were detected and they
    are only of cosmetic nature. These were fixed to allow for
    better comparability of real changes in the yml file.
    MaxThomasHPI committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    df8d52b View commit details
    Browse the repository at this point in the history
  2. Align style further to old style 2

    Another alignment to fit the od style to avoid
    unnecessary change tracking.
    MaxThomasHPI committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    5dc27e3 View commit details
    Browse the repository at this point in the history
  3. Correct mistake in repeatFrequency

    The repeatFrequency contained the following
    attributes which should be on the same level
    as repeateFrequency. The mistake is corrected
    to fit the intended schema.
    
    This is also removing some validation errors.
    MaxThomasHPI committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    877973d View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Correct mistake in hasPart

    The LearningItem object in the hasPart attribute had a
    mistake. The required attribute was on the wrong level.
    Correction of will make the attribute hasPart work as
    expected again.
    
    This also erases a validation error in the yml file.
    MaxThomasHPI committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    d4610b8 View commit details
    Browse the repository at this point in the history
  2. Fix further validation errors

    There was a problem in the "Problem" part of the yml file.
    the required attribute as well as readOnly and x-examples
    were at the wrong level.
    
    Fixing this erases validation errors in the yml file and
    leads to fewer unwanted changes to be tracked.
    
    Also corrects a mistake that tags now is an array as
    intended.
    MaxThomasHPI committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    348db23 View commit details
    Browse the repository at this point in the history
  3. Adjust indenting in JSON schema

    The indention of the old file and the new version were
    different. This made it impossible to track changes.
    MaxThomasHPI committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    522f7a3 View commit details
    Browse the repository at this point in the history
  4. Fix error in properties in JSON schema

    The level the data object was stored in the JSON schema was
    wrong. Now the data is stored as intended at the same level
    as the links.
    MaxThomasHPI committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    fe3db4b View commit details
    Browse the repository at this point in the history
  5. Fix error in license (overall course license)

    The There was a problem that the license attribute contained
    an array of arrays of License objects. Intended is to have
    the license attribute of the course storing an array of License
    objects.
    MaxThomasHPI committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    6f84c9c View commit details
    Browse the repository at this point in the history
  6. Fix error in educationalLevel (overall course level)

    The There was a problem that the educationalLevel attribute
    did not contain an array of EducationalLevel objects. Intended
    is to have the educationalLevel attribute of the course storing
    an array of EducationalLevel objects.
    MaxThomasHPI committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    15b9b96 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Configuration menu
    Copy the full SHA
    1f8a2ea View commit details
    Browse the repository at this point in the history
  2. Fix problem with license example

    The example is now matching the identifier and is pointing
    at the respective spdx url. It complies to the rules set in
    the description now.
    MaxThomasHPI committed May 16, 2024
    Configuration menu
    Copy the full SHA
    78ab7df View commit details
    Browse the repository at this point in the history
  3. Fix problem with example url to images

    Before the change the link pointed at images on the azure
    server and are not valid any longer. The new links are
    working and point an existing image that is reachable.
    MaxThomasHPI committed May 16, 2024
    Configuration menu
    Copy the full SHA
    76ff9b3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e4b781f View commit details
    Browse the repository at this point in the history
  5. Reverse yml to old style referencing

    The changes could not be reviewed because of too many
    changes. The referencing style is now again like in the
    former version.
    
    There still seems to be an advantage in outsourcing
    repeating parts in extra files.
    MaxThomasHPI committed May 16, 2024
    Configuration menu
    Copy the full SHA
    121cecb View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    34426bb View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Update version to 3.0.1

    Only minor changes were made. The functionality
    was not altered. The change is mainly for
    solving inconveniences, update examples, ...
    MaxThomasHPI committed May 17, 2024
    Configuration menu
    Copy the full SHA
    7931414 View commit details
    Browse the repository at this point in the history