Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FP-2406: Make menu be able to persist on IDE #218

Merged
merged 2 commits into from
May 5, 2023
Merged

FP-2406: Make menu be able to persist on IDE #218

merged 2 commits into from
May 5, 2023

Conversation

manuelnogueiramov
Copy link
Contributor

@manuelnogueiramov manuelnogueiramov commented May 3, 2023 •
edited by jira bot
Loading

FP-2406

  • Added a way to make it look like the menu is persistent if it gets unmounted.
  • Minor refactor

@manuelnogueiramov manuelnogueiramov added bug Something isn't working refactor When some refactor was done labels May 3, 2023
@manuelnogueiramov manuelnogueiramov requested a review from a team as a code owner May 3, 2023 19:42
@manuelnogueiramov manuelnogueiramov self-assigned this May 3, 2023
@manuelnogueiramov manuelnogueiramov mentioned this pull request May 3, 2023
Merged
@sonarcloud
Copy link

sonarcloud bot commented May 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@PedroCristovao-Movai PedroCristovao-Movai merged commit ef28dfb into dev May 5, 2023
@PedroCristovao-Movai PedroCristovao-Movai deleted the bugfix/2406-make-menu-persist-IDE branch May 5, 2023 16:35
@PedroCristovao-Movai PedroCristovao-Movai mentioned this pull request May 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@manuelnogueiramov manuelnogueiramov

Labels
bug Something isn't working refactor When some refactor was done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manuelnogueiramov @PedroCristovao-Movai