DP-1017 - Troubleshoot linting issue #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mariana-dias-alves
commented
Jul 19, 2023
•
mariana-dias-alves
commented
- Fixing CICD run on each Pull request is failing with no reason on PR linting step
- Update ros-buildtools-noetic to v2.0.3
- Make sure you are opening from a topic/feature/bugfix branch
- Ensure that the PR title represents the desired changes
- Ensure that the PR description detail the desired changes
- Link to relevant issues in GitHub or Jira
- Link to relevant pull requests, esp. upstream and downstream changes
- Ensure you have provided tests - that demonstrates feature works or fixes the issue
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
|
Kudos, SonarCloud Quality Gate passed!
|
mariana-dias-alves
requested review from
AlexFernandes-MOVAI and
MithunKinarullathil
AlexFernandes-MOVAI
approved these changes
Jul 19, 2023
AlexFernandes-MOVAI
changed the title
MithunKinarullathil
approved these changes
Jul 20, 2023
|
@mariana-dias-alves Congrats on your first PR. The branches we use start with the lower letter prefixes: |
duartecoelhomovai
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.