Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Comprehensive support to R2R transforms. #9

Merged
merged 3 commits into from
Aug 20, 2024
Merged

WIP: Comprehensive support to R2R transforms. #9

merged 3 commits into from
Aug 20, 2024

Conversation

rainwoodman
Copy link
Collaborator

This is a work in progress PR to add comprehensave support to R2R transforms.

  • Fixes Segmentation fault when R2R transform #8.
  • Add a basic correctness test on the H2RC and RC2H R2R transform
  • Add the interface to specify different kinds / directions for R2C transform axes.
  • Find the roundtrip transform pairs and add test cases to roundtrip.py.

@rainwoodman rainwoodman mentioned this pull request Oct 23, 2018
Closed
@rainwoodman
Copy link
Collaborator Author

Use case example FFTW:

https://github.com/knaidoo29/falcon/blob/cb3555ac8b45090bb80d5624b09212cc2a353b79/reference/NumCal.cpp

It is not the R2HC transform.

@rainwoodman
Copy link
Collaborator Author

https://github.com/GEM3D/pressurePoissonSolver/blob/e9c5152d12885cf911e66fc6ec7f1dc3e9101264/domain_decomp/3D-petsc-example/PatchSolvers/FftwPatchSolver.cpp

@rainwoodman
Copy link
Collaborator Author

https://github.com/GEM3D/pressurePoissonSolver/blob/e9c5152d12885cf911e66fc6ec7f1dc3e9101264/domain_decomp/2D-example/Domain.cpp

@rainwoodman @sbird
Add a test case that crashes on r2r.
78892ce
@rainwoodman @sbird
Add very limited r2r support.
17b4d1b 
full R2HC and HC2R of nd transforms are supported.

I do not think this is desired, and I do not know how to assert if
the results are correct.
@rainwoodman @sbird
use void* in PLAN_FUNC table.
f16f776
@sbird
Copy link
Member

sbird commented Aug 20, 2024

Rebased so the test case runs

@sbird sbird merged commit aaf907a into master Aug 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segmentation fault when R2R transform
2 participants
@rainwoodman @sbird