Fix region masking in observations #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `nCells` multi-index produced by xarray's `stack()` method seems to cause trouble between mask arrays and datasets. This may be a change in dask or in xarray itself. The solution seems to be simply to drop the multi-index.
TestingThe results of the regression suite on Anvil are here: All analysis was produced successfully, whereas regional TS diagrams and time series were not completing before this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears a recent change in xarray or dask has broken the way MPAS-Analysis currently handles region masking on lon/lat grids (i.e. for observations). A seemingly inconsistent multi-index called
nCellsis generated when going from the 2D lon/lat space to a 1D "unraveled" coordinate. The easiest way to handle this seems to just be to drop thenCellsmulti-index from both the mask and the data set to be masked.