Fix hovmoller plot comparison #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to wait for #901 so we have a clean run of the test suite. |
Sometimes, runs have slightly different Time values in timeSeriesStatsMonthly (seemingly related to restarts). When this happens, the hovmoller differences are only at times that match exactly, leading to a diff field with the wrong size. This merge fixes the issue by first checking to make sure the two runs start and end at (approximately) the same time, then using the time from the "main" run for the "reference" run, too.
xylar
force-pushed
the
fix_hovmoller
branch
from
7891c0e to
72c2948
Compare
TestingResults of the test suite on Anvil are here: Following #901 and #902, the test suite runs all analysis successfully. The hovmoller comparison looks right: However, the bigger test is that the comparison that @jonbob was running also works now, whereas it failed with E3SM-Unified 1.7.0 and a recent version of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, runs have slightly different Time values in timeSeriesStatsMonthly (seemingly related to restarts). When this happens, the hovmoller differences are only at times that match exactly, leading to a diff field with the wrong size.
This merge fixes the issue by first checking to make sure the two runs start and end at (approximately) the same time, then using the time from the "main" run for the "reference" run, too.