Fixes to formatting and config options for climatologyMapBSF #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase the height of polar plots so titles don't collide.
|
I'm seeing errors in 89 tasks and subtasks when I test this, the same as I was seeing in #915. Something with xarray? I'll continue to debug it tonight... |
There seems to have been a bug fix in xarray and the spurious nCells index variable no longer gets created. We need to drop it only if it is present (in older xarray).
TestingThe Anvil test suite ran successfully. Results are here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#898 introduced some minor bugs and formatting issues that this merge aims to clean up.
This merge also fixes a slightly complicated issues with xarray. Previously, we needed to drop an index variable that was introduced by stacking. That index variable seems to have been introduced inadvertently and is no longer present in the latest xarray. However, dropping this now nonexistent variable causes problems. This merge introduces checks so that we only drop that variable if it is present.