Fix masking of Hovmoller plots on different meshes #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want the more restrictive mask (with shallower bathymetry) for comparing Hovmoller plots on different meshes.
TestingI ran Hovmoller comparison analysis between the SORRM and EC meshes that had previously failed. With these changes, it was successful: |
|
@darincomeau, could you verify that this fixes the problem for you, too? |
|
Thanks @xylar! I ended up testing this on the same set of runs, and it indeed worked for me: |
darincomeau
approved these changes
Nov 30, 2022
|
Thanks @darincomeau! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want the more restrictive mask (with shallower bathymetry) for comparing Hovmoller plots on different meshes.