Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update geometric_features to 1.2.0 #957

Merged
merged 2 commits into from
Apr 11, 2023
Merged

Update geometric_features to 1.2.0 #957

merged 2 commits into from
Apr 11, 2023

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Apr 10, 2023

This brings in new definitions of the Weddell and Bellingshausen seas from MPAS-Dev/geometric_features#195

@xylar xylar self-assigned this Apr 10, 2023
@xylar
Copy link
Collaborator Author

xylar commented Apr 10, 2023

Testing will have to wait until LCRC maintenance is done.

@xylar
Copy link
Collaborator Author

xylar commented Apr 11, 2023

Testing

I ran the developer's suite with the new geometric features:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xasay-davis/analysis_testing/chrysalis/update_geometric_features/

As expected, plots show the new regions, e.g.:
image

@xylar xylar merged commit ffb5c24 into MPAS-Dev:develop Apr 11, 2023
@xylar xylar deleted the update_geometric_features branch April 11, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@xylar xylar

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xylar