Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coordinate order for Schmidtko seafloor T and S #963

Merged
merged 1 commit into from
May 30, 2023

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented May 30, 2023

We need to rename x <---> y for the Schmidtko observations. This hasn't been an issue up to now because we happened to be using square comparison grids but causes trouble when len(x) != len(y), as in the FRIS comparison grid we're using for a paper.

@xylar xylar added the bug label May 30, 2023
@xylar xylar self-assigned this May 30, 2023
@xylar
Copy link
Collaborator Author

xylar commented May 30, 2023

Testing

With this fix, I'm able to plot Schmidtko data on a non-square FRIS comparison grid. Before this change, I was not.

@xylar xylar merged commit 85466ac into MPAS-Dev:develop May 30, 2023
@xylar xylar deleted the fix-schmidtko-x-y branch May 30, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant