Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dims --> sizes for xarray datasets #983

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Feb 5, 2024

This should prevent a large number of deprecation warnings that we are getting.

@xylar xylar added the clean up label Feb 5, 2024
@xylar xylar self-assigned this Feb 5, 2024
xylar added 2 commits February 6, 2024 15:27
This should prevent a large number of deprecation warnings that
we are getting.
@xylar xylar force-pushed the fix-xarray-dataset-sizes branch from 56f3a69 to cae8a36 Compare February 6, 2024 21:27
@xylar
Copy link
Collaborator Author

xylar commented Feb 6, 2024

Testing

With both this branch and MPAS-Dev/pyremap#60, the deprecation warnings all disappear. The test suite completed successfully:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xylar/analysis_testing/chrysalis/fix-xarray-dataset-sizes/

@xylar xylar merged commit d98b448 into MPAS-Dev:develop Feb 6, 2024
5 checks passed
@xylar xylar deleted the fix-xarray-dataset-sizes branch February 6, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant