Removed errorOnMissing and endYear = end config options
#991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We always want an error on missing data
|
@cbegeman and @milenaveneziani, please let me know if you agree that these are options we no longer want to support. I was trying to fix |
Results are unpredictable and this option causes more trouble for development than it is worth.
xylar
force-pushed
the
remove-end-year-end
branch
from
78686de to
00a3101
Compare
xylar
force-pushed
the
remove-end-year-end
branch
from
00a3101 to
10dd8de
Compare
|
Thanks @cbegeman! |
|
@milenaveneziani, do you have time to look this over and let me know if you're okay with it? |
|
oops, sorry @xylar that I missed this! |
milenaveneziani
approved these changes
Mar 14, 2024
|
No worries, thanks @milenaveneziani ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge removes the config option
errorOnMissingfrom the[input]section. In practice, we always want an error on missing data, rather than simply providing a warning using available data.This merge also drops support for the
endvalue forendYear. For developers,endhas been more difficult to support than it is worth. For users, it isn't a great idea to have the same analysis run produce different results depending on how far along a simulation is. In practice, we always want to run fresh analysis when we want a longer time series.