Initialization of the f_* flags in physics parameterizations #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ale-reference suite uses the nTiedtke (cu_ntiedtke) and not the tiedtke (cu_tiedtke) parameterization of deep and shallow convection. One motivation of using the cu_ntiedtke option instead of cu_tiedtke is the scale-aware capability of the nTiedtke parameterization, allowing the use of nTiedtke iwth variable-resolution meshes. -> therefore, we decided to rename the package cu_tiedtke_in to cu_ntiedtke_in.
… f_qv, f_qr, and f_qs in module_cu_tiedtke.F and module_cu_ntiedtke.F. Those three variables are not used in the parameterizations. * In ./src/core_atmosphere/physics/mpas_atmphys_driver_convection.F, removed f_qv, f_qr, and f_qs in the calls to cu_tiedtke and cu_ntiedtke.
… f_qv and f_qc in module_cu_kfeta.F. Those two variables are not used in the parameterization. * In ./src/core_atmosphere/physics/mpas_atmphys_driver_convection.F, removed f_qv and f_qc in the call to kf_eta_cps.
…added comments at the top of module.
… f_qv and f_qc in module_ra_cam.F (subroutine camrad). Those two variables are not used in the parameterization. * In ./src/core_atmosphere/physics/mpas_atmphys_driver_radiation_lw(sw).F, removed f_qv and f_qc in the calls to camrad.
…ariable f_qv which is not needed in any of the physics parameterizations.
-> in mpas_atmphys_vars.F, removed the "parameter" definition for f_qc,f_qr,f_qi,
f_qs,f_qg,f_nc,and f_ni. these variables are now simply defined as logicals.
also renamed f_qnc to f_nc, and f_qni to f_ni.
-> in mpas_atmphys_init.F, added subroutine init_physics_flags to initialize f_qc,
f_qr,f_qi,f_qs,f_nc,and f_ni.
-> in mpas_atmphys_driver_pbl.F, changed the call in mynn_bl_driver after renaming
f_qnc to f_nc, and f_qni to f_ni.
mgduda
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I revised the initialization of the flags f_qc, f_qi, f_qr, f_qs, f_qg, f_ni, and f_nc which control which cloud condensate mixing ratios (qc, qr, qi, qs, qg) and cloud number concentrations (nc, ni) are used in the physics parameterizations. Note that the flag f_qv was removed from all physics parameterizations because the mixing ratio qv is always needed.
In the original sourcecode, the flags were defined and set to true (or false) manually in mpas_atmphys_vars.F. In the updated sourcecode, the flags are now initialized in subroutine init_physics_flags in mpas_atmphys_init.F. Flags are set to true if the corresponding cloud condensates and number concentrations are actually allocated at run time.