Updated the calculation of the 2-meter temperature, potential temperature, and specfic humidity over seaice points #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-> renamed module mpas_atmphys_driver_lsm_shared.F to mpas_atmphys_lsm_shared.F.
-> in mpas_atmphys_driver_lsm.F, now use mpas_atmphys_lsm_shared to call subroutine
correct_tsk_over_seaice. removed subroutine correct_tsk_over_seaice at the bottom
of the module.
-> corrected Makefile accordingly.
|
Is this a fix that should be included in v8.0.2? |
…gh the local variables needed in the calculation of t2m, th2m, and q2 prior to updating all LSM variables (see subroutine lsm_to_MPAS).
…he call to sfcdiags from subroutine driver_lsm to subroutine lsm_to_MPAS. This allows t2m, th2m, and q2 to be correctly computed over seaice points.
ldfowler58
force-pushed
the
NSF-MPAS/lsm_sfcdiags
branch
from
264f970 to
348f404
Compare
|
Hi Michael:
Thanks for looking at this. It is not a bug fix (it is not a coding bug)
since MPAS has been running like that for years; but it is a fix in the
sense that it makes more sense to have those diagnostics computed after the
variables that are used to compute them include the impact of the seaice
fraction. Note that I had to rebase that branch using the previous PR
(lsm_shared). I had to do this in preparation to add another PR before
Noah-MP.
Should have some time later this afternoon about the bug in the Thompson
cloud microphysics.
Thanks,
Laura
…On Wed, Mar 13, 2024 at 10:53 AM Michael Duda ***@***.***> wrote:
Is this a fix that should be included in v8.0.2?
—
Reply to this email directly, view it on GitHub
<#1147 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7LEXTUHJWYFM6HE24AD5LYYCABLAVCNFSM6AAAAABETARRS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJUHE3TMNJQGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
!-------------------------------------------------------------------------------------------------------------
Laura D. Fowler
Mesoscale and Microscale Meteorology Division (MMM)
NSF - National Center for Atmospheric Research
P.O. Box 3000, Boulder CO 80307-3000
e-mail: ***@***.***
phone: 303-497-1628
!-------------------------------------------------------------------------------------------------------------
|
mgduda
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In MPAS-v8.0.1, the 2-meter temperature (t2m), potential temperature (th2m), and specific humidity (q2) are computed in subroutine sfcdiags which is called immediately after the call to seaice_noah in subroutine driver_lsm (see mpas_atmphys_driver_lsm.F). This implies that the input variables in subroutine sfcdiags have not yet been weighted by the seaice fraction which in turn impacts the calculation of the 2-meter diagnostics.
In order to have t2m, th2m, and q2 to depend on the seaice fraction, we moved the correction of local variables as functions of the seaice fraction and call to subroutine sfcdiags at the top of subroutine lsm_to_MPAS.