Generalization of advection-related subroutines in mpas_atm_time_integration.F #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_advance_scalars_mono_work
so that they can be called with state arrays different than "scalars":
-> in subroutine advance_scalars, modified the line:
call mpas_pool_get_dimension(state, 'num_scalars', num_scalars)
to
call mpas_pool_get_dimension(state, 'num_'//trim(field_name), num_scalars)
to expand the definition of num_scalars to state arrays different than "scalars".
-> in subroutine atm_advance_scalars_mono_work, modified the line:
call exchange_halo_group(block % domain, 'dynamics:scalars_old')
to
call exchange_halo_group(block % domain, 'dynamics:'//trim(field_name)//'_old')
so that halo exchange can be applied to state arrays different than "scalars".
mgduda
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a couple of corrections to subroutines related to advection of "scalars" like arrays in mpas_atm_time_integration.F. These corrections will allow us to call subroutine advance_scalars for
state-related arrays different than scalars (for instance, aerosols and passive tracers).
We modified two subroutines:
In subroutine advance_scalars, we replaced 'num_scalars' with 'num_'//trim(field_name) (see line 1355).
In subroutine atm_advance_scalars_mono_work, we replaced 'dynamics:'scalars_old' with 'dynamics:'//trim(field_name)//'_old' (see line 3405).