Work around Noah-MP compilation issues with GNU -std=f2008 flag #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At present, the Noah-MP code fails to compile with the GNU compilers using the
-std=f2008 flag, which is included in the FFLAGS set for the 'gnu' build
target:
RunoffSurfaceDynamicVicMod.F90:205:4:
151 | goto 1003
| 2
......
205 | 1003 if ( DepthYTmp <= 0.0 ) DepthYTmp = 0.0
| 1
Error: Legacy Extension: Label at (1) is not in the same block as the GOTO statement at (2)
RunoffSurfaceDynamicVicMod.F90:205:4:
175 | goto 1003
| 2
......
205 | 1003 if ( DepthYTmp <= 0.0 ) DepthYTmp = 0.0
| 1
Error: Legacy Extension: Label at (1) is not in the same block as the GOTO statement at (2)
As a work-around for this issue, this commit adds logic to the Noah-MP Makefile
to remove '-std=f2008' if it is present in FFLAGS. The modified FFLAGS are only
used when compiling Noah-MP, and so Fortran 2008 compliance is still enforced
for other code when building with the 'gnu' target.
|
Using "gcc/12.2.0" and "make gnu CORE=atmosphere, I was able to compile MPAS-Model without any issues. I definitely approve the PR. Thanks for adding the bug fix in the Makefile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a work-around for Noah-MP compilation issues with the GNU
-std=f2008flag.At present, the Noah-MP code fails to compile with the GNU compilers using the
-std=f2008flag, which is included in theFFLAGSset for the 'gnu' build target:As a work-around for this issue, this PR adds logic to the Noah-MP
Makefileto remove-std=f2008if it is present inFFLAGS. The modifiedFFLAGSare only used when compiling Noah-MP, and so Fortran 2008 compliance is still enforced for other code when building with the 'gnu' target.