Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ONLY clause to USE statements for the 'mpi_f08' module #1188

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

mgduda
Copy link
Contributor

@mgduda mgduda commented Jun 20, 2024

This PR adds ONLY clauses to all USE statements for the mpi_f08 module in MPAS.

Besides being a generally good practice, the use of only those entities from the 'mpi_f08' module that are actually needed eliminates link-time issues with debug builds using the Intel oneAPI compilers (with the Cray MPICH library).

Besides being a generally good practice, the use of only those entities from the
'mpi_f08' module that are actually needed eliminates link-time issues with debug
builds using the Intel oneAPI compilers (with the Cray MPICH library).
@mgduda
Copy link
Contributor Author

mgduda commented Jun 20, 2024

When combined with PR #1187, DEBUG=true builds with the intel/2024.0.2 module on Derecho should be successful. However, runs fail almost immediately due to what look like issues with uninitialized variables. So there may be another PR needed to turn off some checks (for example, changing -check all to something like -check pointers,bounds).

Copy link
Collaborator

@gdicker1 gdicker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you say, these changes are best practice and make sense. Approved by inspection.

@mgduda mgduda changed the base branch from develop to release-v8.2.0 June 21, 2024 15:57
@mgduda mgduda merged commit d00c950 into MPAS-Dev:release-v8.2.0 Jun 21, 2024
@mgduda mgduda deleted the framework/mpi_f08_use_only branch June 21, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants