Fix instances of unbalanced quotes in init_atmosphere and atmosphere registries #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdicker1
approved these changes
Jun 27, 2024
|
I'll update the commit message and PR description (but no changes to diffs) with a few more details. The registry-generated code is different in ways that I'm testing more carefully. For example, we previously had generated code like this for whereas we now get The latter is clearly correct while the badly nested quotes led to the former incorrect code. |
mgduda
force-pushed
the
atmosphere/fix_registry_syntax_errs
branch
from
cd16baf to
6435c15
Compare
weiwangncar
approved these changes
Jun 27, 2024
…egistries
This commit fixes several instances of unbalanced or badly nested quotes in
the init_atmosphere and atmosphere Registry.xml files. These changes result
in different registry-generated code. For example, the generated code for
rnifampten attributes looked like:
call mpas_add_att(r2Ptr % attLists(1) % attList, 'long_name', 'tendency of ')
call mpas_add_att(r2Ptr % attLists(1) % attList, 'ice-friendly"', '')
call mpas_add_att(r2Ptr % attLists(1) % attList, 'aerosol', '')
call mpas_add_att(r2Ptr % attLists(1) % attList, 'number', '')
call mpas_add_att(r2Ptr % attLists(1) % attList, 'concentration', '')
call mpas_add_att(r2Ptr % attLists(1) % attList, 'due', '')
call mpas_add_att(r2Ptr % attLists(1) % attList, 'to', '')
call mpas_add_att(r2Ptr % attLists(1) % attList, 'microphysics"', '')
before the changes in this commit, whereas it now looks like:
call mpas_add_att(r2Ptr % attLists(1) % attList, 'long_name', 'tendency of ice-friendly aerosol number concentration due to &
µphysics')
The latter is clearly correct while the badly nested quotes led to the former
incorrect code.
mgduda
force-pushed
the
atmosphere/fix_registry_syntax_errs
branch
from
6435c15 to
8263af9
Compare
|
The last force-push just corrects a typo in the commit message. |
mgduda
added a commit
that referenced
this pull request
Jun 27, 2024
…0 (PR #1195) This merge fixes several instances of unbalanced quotes in the init_atmosphere and atmosphere Registy.xml files. * atmosphere/fix_registry_syntax_errs: Fix instances of unbalanced quotes in init_atmosphere and atmosphere registries
mgduda
added a commit
that referenced
this pull request
Jun 27, 2024
…0 (PR #1195) This merge fixes several instances of unbalanced or badly nested quotes in the init_atmosphere and atmosphere Registry.xml files. These changes result in different registry-generated code. For example, the generated code for rnifampten attributes looked like call mpas_add_att(r2Ptr % attLists(1) % attList, 'long_name', 'tendency of ') call mpas_add_att(r2Ptr % attLists(1) % attList, 'ice-friendly"', '') call mpas_add_att(r2Ptr % attLists(1) % attList, 'aerosol', '') call mpas_add_att(r2Ptr % attLists(1) % attList, 'number', '') call mpas_add_att(r2Ptr % attLists(1) % attList, 'concentration', '') call mpas_add_att(r2Ptr % attLists(1) % attList, 'due', '') call mpas_add_att(r2Ptr % attLists(1) % attList, 'to', '') call mpas_add_att(r2Ptr % attLists(1) % attList, 'microphysics"', '') before the changes in this merge, whereas it now looks like call mpas_add_att(r2Ptr % attLists(1) % attList, 'long_name', 'tendency of ice-friendly aerosol number concentration due to & µphysics') The new generated code is correct, while the previously generated code was clearly incorrect. * atmosphere/fix_registry_syntax_errs: Fix instances of incorrect quotes in init_atmosphere and atmosphere registries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several instances of unbalanced quotes in the
init_atmosphereandatmosphereRegisty.xmlfiles.