Skip to content

Add a chemistry package structure #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

K20shores
Copy link

@K20shores K20shores commented Jun 24, 2025

This is continued from where Matt left off since it already seemed mostly correct to me. I'll update the PR description when we know if this is an expected structure

will refactor this to do this:

  • single folder called chemistry
    • single file called chemistry.F with an init, run and finalize
    • This file will call musica things, which maybe is placed in chemistry/musica
    • All chemistry things should be here and called from core_atmosphere or maybe init_atmosphere
    • It would be nice to have both direct updates of the concentrations as well as tendencies

@K20shores K20shores changed the base branch from master to develop June 24, 2025 15:04
@K20shores K20shores changed the title Basic chemistry package Add a chemistry package structure Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants