Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove COMPASS from CI and Docs #752

Merged
merged 2 commits into from
Jan 15, 2021
Merged

Remove COMPASS from CI and Docs #752

merged 2 commits into from
Jan 15, 2021

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Nov 10, 2020

This merge removes COMPASS tests from Azure CI and from the MPAS-Model documentation produced by Azure (http://mpas-dev.github.io/MPAS-Model/latest/)

@xylar xylar added COMPASS Documentation only Changes that impact code comments and documentation, but no executable code CI only Changes only affect Azure Pipelines CI, not the code or documentation labels Nov 10, 2020
@xylar xylar self-assigned this Nov 10, 2020
@xylar
Copy link
Collaborator Author

xylar commented Nov 10, 2020

@mark-petersen and @matthewhoffman, since this is a PR to develop related to moving COMPASS to https://github.com/MPAS-Dev/compass, I figured I would get your approval before I remove the docs and testing that has been moved over, just in case.

mark-petersen
mark-petersen approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree we need to move compass documentation to the compass repo. Thanks.

@mark-petersen
Copy link
Contributor

Will try to merge this in soon on an off day.

matthewhoffman
matthewhoffman approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@matthewhoffman matthewhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. I never fully understood how CI is set up, so I'm approving based on the fact that it is only removing files I am not familiar with. :)

@xylar
Copy link
Collaborator Author

xylar commented Nov 18, 2020

I never fully understood how CI is set up

@matthewhoffman, I'm assuming you're happy to keep it that way, but I'm happy to explain it to you anytime you like.

@xylar xylar removed the request for review from vanroekel January 15, 2021 19:55
@xylar xylar force-pushed the ci/remove_compass branch from dc101e6 to 0f978c3 Compare January 15, 2021 20:01
@xylar
Copy link
Collaborator Author

xylar commented Jan 15, 2021

@mark-petersen, I'm not sure why you added @vanroekel as a reviewer. I have removed him. I don't think this is really in his wheelhouse and I don't think he was aware he was added. (@vanroekel, you are welcome to comment but I think develop isn't really a branch you keep too much track of.)

@xylar
Copy link
Collaborator Author

xylar commented Jan 15, 2021

I'm going to go ahead and merge this. I think it's just collecting dust.

@xylar xylar merged commit 3f3747f into MPAS-Dev:develop Jan 15, 2021
@xylar xylar deleted the ci/remove_compass branch January 15, 2021 20:05
@xylar
Copy link
Collaborator Author

xylar commented Jan 22, 2021

@mark-petersen, I would like to have develop merged into ocean/develop to bring in these changes when there is a convenient chance to do that. I could do it as a PR if that makes it easier for E3SM.

There is a merge conflict because 2 files removed here have been modified in ocean/develop: #653. These files should just be removed as part of the merge.

@matthewhoffman matthewhoffman added CI only Changes only affect Azure Pipelines CI, not the code or documentation COMPASS Documentation only Changes that impact code comments and documentation, but no executable code labels Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewhoffman matthewhoffman matthewhoffman approved these changes

@mark-petersen mark-petersen mark-petersen approved these changes

Assignees

@xylar xylar

Labels
CI only Changes only affect Azure Pipelines CI, not the code or documentation COMPASS Documentation only Changes that impact code comments and documentation, but no executable code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xylar @mark-petersen @matthewhoffman